added Eslint, Prettier and Ruff to repo #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrey150
approved these changes
Dec 24, 2025
Contributor
shrey150
left a comment
shrey150
left a comment
There was a problem hiding this comment.
Pre-approving, would address nits before merging!
python/business-lookup/README.md
Outdated
| 5) Add required API keys/IDs to .env | ||
| 6) python main.py | ||
|
|
||
| 1. python -m venv venv |
Contributor
There was a problem hiding this comment.
Do we want to use this opportunity to use uv venv instead? (as well as in all other READMEs?)
python/business-lookup/README.md
Outdated
| 2. source venv/bin/activate # On Windows: venv\Scripts\activate | ||
| 3. uvx install stagehand python-dotenv pydantic | ||
| 4. cp .env.example .env | ||
| 5. Add required API keys/IDs to .env |
Contributor
There was a problem hiding this comment.
For consistency, #5 should probably be a comment
| 🎮 Browserbase: https://www.browserbase.com | ||
| 💡 Try it out: https://www.browserbase.com/playground | ||
| 🔧 Templates: https://www.browserbase.com/templates | ||
| 📧 Need help? [email protected] |
Contributor
There was a problem hiding this comment.
Mind tagging the Discord here? http://stagehand.dev/discord
Comment on lines
30
to
31
| 5. Add your Browserbase API key, Project ID, and Google Generative AI API key to .env | ||
| 6. Edit COMPANY_NAMES array in main.py to specify which companies to process |
Contributor
There was a problem hiding this comment.
I think these should be comments too -- just like above feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ESLint and Ruff for TypeScript and Python linting
This PR adds linting and formatting tools to maintain code quality across the templates repository.
Changes
TypeScript/JavaScript:
Added ESLint with TypeScript support
Configured with Prettier integration (no conflicts)
Set unused variables to warnings (lenient for template/example code)
Added scripts: pnpm lint and pnpm lint:fix
Python:
Added Ruff for Python linting (via uvx)
Configured with lenient rules for template/example code
Auto-fixed 287 linting issues (whitespace, imports, type annotations)
Added scripts: pnpm lint:python, pnpm lint:python:fix, pnpm format:python
Formatted all Python files (16 files)
Configuration
ESLint: Warns on unused vars (allows _ prefix), works with Prettier
Ruff: Ignores strict naming conventions (N815, N806) for template code
Both tools configured to be lenient for example/template code